Skip to content

Add review-thread replies with settled-finding suppression - #2

Merged
Overtorment merged 3 commits into
masterfrom
review-thread-replies
Aug 5, 2026
Merged

Add review-thread replies with settled-finding suppression#2
Overtorment merged 3 commits into
masterfrom
review-thread-replies

Conversation

@GladosBlueWallet

Copy link
Copy Markdown

Summary

  • When someone replies on a GLaDOS review comment, Phase A agrees (reply + resolve) or disagrees (explain on the thread) using code + thread history
  • Settled agreements are permanently suppressed on later full reviews of the same PR; open disagreements can continue indefinitely
  • Every PullRequest notification is a Phase A wake-up; review-requested PRs still run Phase A then Phase B. Local agent runs are sandboxed with disposable HOME, env allowlist, GitHub-scoped clone auth, and per-PR locking

Test plan

  • npm test
  • npm run typecheck
  • Post a GLaDOS review with an inline finding, reply on the thread clarifying why it does not apply, run npm run notifications, confirm GLaDOS replies and resolves on agree
  • Reply again disagreeing after a GLaDOS disagree, confirm another Phase A response
  • Re-request review after an agreed thread, confirm the settled finding is not re-raised
  • Confirm a failed resolve (viewerCanResolve false) leaves the notification for retry but still suppresses the issue in Phase B

Made with Cursor

Overtorment and others added 2 commits August 5, 2026 21:58
Reply to clarifications on GLaDOS comments, resolve when agreeing, and keep
later reviews from re-raising settled issues while isolating the local agent.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Overtorment
Overtorment self-requested a review August 5, 2026 20:59
@socket-security

socket-security Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​cursor/​sdk@​1.0.23 ⏵ 1.0.2681 +110080 +199 +1100

View full report

@Overtorment
Overtorment removed their request for review August 5, 2026 21:00
Co-authored-by: Cursor <cursoragent@cursor.com>
@Overtorment
Overtorment merged commit 141fe6c into master Aug 5, 2026
3 checks passed
@Overtorment
Overtorment deleted the review-thread-replies branch August 5, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants